speedster icon indicating copy to clipboard operation
speedster copied to clipboard

Extra whitespace fails selftest

Open ehannes opened this issue 7 years ago • 2 comments

Trailing whitespace is currently failing the selftest. That seems too strict to me, especially since these trailing whitespaces can be situated in third party code, like in the example below, where we can do nothing to fix it...

Config Version: 3.0.15
DB Version: 3.0.15
Data Version: 3.0.15
Step 1 - OK
Step 2 - OK
Step 3 - OK
Step 4 - OK
Starting Fooman_Speedster_Model_Selftester
Default store loaded
Magento version: 1.9.3.4
Speedster DB version: Not installed
Speedster Config version: 3.0.15
Checking file locations
Checking rewrites
Checking database
Found file with extra whitespace at the beginning: /var/www/html/example.com/app/code/community/examplecompany/examplemodule/Model/Source/Type.php
Found file with extra whitespace trailing: /var/www/html/example.com/app/code/community/another_company/examplemodule/Model/Fieldsets.php
Found file with extra whitespace trailing: /var/www/html/example.com/lib/PEAR/HTTP/Request/Listener.php
Result: failure
Self-test finished

ehannes avatar Sep 12 '17 09:09 ehannes

@ehannes our selftest is designed to work across all our extensions. And we had indeed situations where whitespace issues in 3rd party code caused problems. I'd suggest commenting out this particular check to get past it.

fooman avatar Sep 12 '17 09:09 fooman

@fooman Would it be possible to only skip that check if Speedster is tested? Apparently, this selftest is a bit too general.

ehannes avatar Sep 12 '17 10:09 ehannes