foodsoft icon indicating copy to clipboard operation
foodsoft copied to clipboard

Add ability to include custom gems

Open kidhab opened this issue 3 years ago • 3 comments

This might be useful if you want to include gems that are not part of this project. E.g. when a Foodsoft hosting provider want to include turnout to inform about maintenance.

kidhab avatar Jan 18 '22 14:01 kidhab

Interesting idea. Gemfile.lock remains an issue here, how to handle that? Can we separate the two ... ?

wvengen avatar Jan 21 '22 14:01 wvengen

I would leave the Gemfile.lock as it is. It's up to the user to update that file if one adds additional gems to Gemfile.local.

kidhab avatar Feb 03 '22 07:02 kidhab

When people start using this, Gemfile.lock would be updated after a bundle install. I'd expect this change to introduce random Gemfile.lock changes in PRs.

Are there drawbacks to echo "gem 'foo'" >>Gemfile && bundle install for a hosting provider?

wvengen avatar Apr 25 '22 12:04 wvengen

I do not think this is a clean solution, since you would need to keep it in sync with Gemfile.lock. IMO hosting providers should install only with bundle install --deployment, which requires that Gemfile.lock is up to date

paroga avatar Oct 13 '22 17:10 paroga

Maybe it would be better to do it the other way and include the Gemfile in a Gemfile.local:

# Gemfile.local
eval File.read('Gemfile')

And then run bundle install --gemfile Gemfile.local

kidhab avatar Oct 25 '22 14:10 kidhab