foodsoft icon indicating copy to clipboard operation
foodsoft copied to clipboard

add currency symbols & improve amount fields in various views

Open twothreenine opened this issue 3 years ago • 2 comments

Currency symbols added to various forms and other views. The new_collection form now also supports decimal commas, fixing #722 (at least the initial issue)

twothreenine avatar Feb 25 '21 01:02 twothreenine

I'd like some feedback on this (and #840 ) before I move on to the next fixes/features ;)

twothreenine avatar Mar 15 '21 10:03 twothreenine

sorry for the late reply, unfortunately this is not an easy change.

You changed the type of the input fields to number. I tried already something similar some time ago, but stopped it, since I wasn't able to get browsers to behave consistent. Did you test ALL changed fields with multiple browsers and multiple locales? This change has potential to break a lot.

The main issue happens when the view prints numbers in german locale (e.g. 12,34), but the input field of type number expects english locales (e.g. 12.34).

paroga avatar Mar 18 '21 11:03 paroga