foodsoft
foodsoft copied to clipboard
foodcoops
set cookie expiration
a quick fix for #802
caveat - i have not tested this on the master branch (rails 5) but it works on my fork which uses rails 4.2
Thanks for the PR! While this would be better with 'continue where I left off', doesn't this make it a non-session-cookie, hence keeping the cookie when the browser window is closed with standards-like behaviour?
a session cookie is simply one with no expiry set. (and that behaviour can be different as mentioned in the issue). this pr just sets an expiry of one year.
it is contentious because maybe some user will not want that behaviour (eg, they want to have to log in), but frankly i don't see many strong arguments for that as a default. this change will mean you have to click log out to log out.
Ok, fair enough, thanks for explaining. If anyone has an opinion on this, please join in, otherwise I'd be favoured to merging this after some time.
i'm ok with adding a "remember me" option, but i don't think that a session cookie should have an expire date, regardless what browsers do. i don't like this to get merged
