fontbakery
fontbakery copied to clipboard
[com.google.fonts/check/vertical_metrics_regressions] update for another situation
Observed behaviour
FAIL for legit upgrade. typoLineGap
was equal to 100
so we upgraded the font for it to equal 0. Therefore we added 50 to typoAscender and typoDescender to avoid regression on Windows' browsers.
🔥 FAIL: Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts. (com.google.fonts/check/vertical_metrics_regressions) 🔥 FAIL Mada Regular: OS/2 sTypoAscender is 950 when it should be 900 [code: bad-typo-ascender] 🔥 FAIL Mada Regular: OS/2 sTypoDescender is -350 when it should be -300 [code: bad-typo-descender] 🔥 FAIL Mada Regular: hhea Ascender is 950 when it should be 900 [code: bad-hhea-ascender] 🔥 FAIL Mada Regular: hhea Descender is -350 when it should be -300 [code: bad-hhea-descender]
Expected behaviour
Add a situation:
- If typoLineGap is not equal to 0, and use_typo_metrics is enabled. The typoLineGap value should be evenly distributed between typoAscender and typoDescender and then changed to 0. And
hhea
should then have the same values as thetypo
metrics.