fontbakery icon indicating copy to clipboard operation
fontbakery copied to clipboard

com.google.fonts/check/kerning_for_non_ligated_sequences incorrectly reports missing kerning for hyphen+greater / less+hyphen

Open marcologous opened this issue 5 years ago • 3 comments

Screen Shot 2020-07-02 at 11 09 58 PM

Screen Shot 2020-07-02 at 11 10 31 PM

Screen Shot 2020-07-02 at 11 09 44 PM

marcologous avatar Jul 02 '20 19:07 marcologous

https://travis-ci.org/github/marcologous/hanken-grotesk/builds/704431313#L1496

marcologous avatar Jul 02 '20 19:07 marcologous

Thanks, @marcologous

felipesanches avatar Jul 02 '20 19:07 felipesanches

The reason for this is that kerning_for_non_ligated_sequences only parses Format 1 (glyph pair) subtables, not Format 2 (class pair) subtables. So any class-based kerning pairs will not be noticed.

I'm not convinced about this check anyway. It only makes sense for Latin fonts, and it's not clear to me that "has a ligature" equals "needs kerning". I think it's better achieved through other means. ("Is there kerning between Latin pairs which usually have kerning?")

simoncozens avatar Dec 04 '24 14:12 simoncozens