Pluto.jl icon indicating copy to clipboard operation
Pluto.jl copied to clipboard

Set `AUTO_RELOAD_FROM_FILE_DEFAULT` to `true`

Open rikhuijzer opened this issue 3 years ago • 11 comments

  • Let's enable https://github.com/fonsp/Pluto.jl/pull/1029?

I'm been using it as default for a few months now and it worked flawlessly.

rikhuijzer avatar Jun 08 '22 08:06 rikhuijzer

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="rh/auto-reload-from-file")
julia> using Pluto

github-actions[bot] avatar Jun 08 '22 08:06 github-actions[bot]

Thanks for bringing up this subject again! I also have good experience with it on MacOS, which OS are you using Rik?

I still see that our file watching tests fail about 10% of the time on main (and I manually rerun), so I still don't feel fully confident about it. I was kind of waiting for https://github.com/JuliaPluto/BetterFileWatching.jl/pull/2 , and then switch to BetterFileWatching, which would be a more reliable and production-tested version of file watching.

cc @Pangoraw who better understands the current instabilities and how we can improve

fonsp avatar Jun 08 '22 10:06 fonsp

Thanks for bringing up this subject again! I also have good experience with it on MacOS, which OS are you using Rik?

I'm have been using it on three different Linux systems.

I still see that our file watching tests fail about 10% of the time on main (and I manually rerun), so I still don't feel fully confident about it. I was kind of waiting for https://github.com/JuliaPluto/BetterFileWatching.jl/pull/2 , and then switch to BetterFileWatching, which would be a more reliable and production-tested version of file watching.

Sounds good :+1:

rikhuijzer avatar Jun 08 '22 10:06 rikhuijzer

It would be great to have feedback on windows as it seems more brittle there (the same is currently true for https://github.com/JuliaPluto/BetterFileWatching.jl/pull/2)

Pangoraw avatar Jun 09 '22 16:06 Pangoraw

I played around with the auto reload option on Windows (Win 11, Julia 1.8 RC1) and have not observed any issue.

lungben avatar Jun 13 '22 14:06 lungben

I just noticed yesterday that the auto-reload from file doesn't seem to track file changes in metadata. Do we want also to support that? I guess it would be consistent but is probably best as separate PR

disberd avatar Jun 14 '22 07:06 disberd

I just noticed yesterday that the auto-reload from file doesn't seem to track file changes in metadata. Do we want also to support that? I guess it would be consistent but is probably best as separate PR

Did you make an issue or PR @disberd ?

fonsp avatar Sep 05 '22 11:09 fonsp

Hi @fonsp, I think I did not in the end

disberd avatar Sep 05 '22 12:09 disberd

Can you make one?

fonsp avatar Sep 05 '22 12:09 fonsp

Maybe we can enable it by default on UNIX only?

fonsp avatar Oct 31 '23 09:10 fonsp

I am not sure. It worked for me on Linux, but I don't know what the risks are. If enabled on Linux, then also Mac by default?

rikhuijzer avatar Nov 01 '23 19:11 rikhuijzer