Pluto.jl icon indicating copy to clipboard operation
Pluto.jl copied to clipboard

ExpressionExplorer: `global` stronger than `let`

Open fonsp opened this issue 3 years ago • 2 comments

We have a couple of combinations of let and global that are not analyzed correctly, like:

let
	a = 1
	global a = 2
end

defines a global a, but Pluto prioritizes the let block.

@test_broken means that we still need to fix it:

https://github.com/fonsp/Pluto.jl/blob/c1d23122845e7864ef3dfe15a8428366c98f95eb/test/ExpressionExplorer.jl#L368-L379

This is a good first issue, because the ExpressionExplorer is a small, isolated part of Pluto's codebase. For more info about working on this issue, see:

https://github.com/fonsp/Pluto.jl/blob/c1d23122845e7864ef3dfe15a8428366c98f95eb/test/ExpressionExplorer.jl#L3-L17

fonsp avatar Jan 26 '22 22:01 fonsp

Is the following issue still open?

StarTrooper08 avatar Mar 20 '22 11:03 StarTrooper08

Yes!

fonsp avatar Mar 20 '22 13:03 fonsp