João Pedro Fonseca Dantas
João Pedro Fonseca Dantas
@mjsax, I would like to suggest that we adopt "skip repartitioning" instead of "mark as partitioned". It seems to me to be more consistent with the rest of the KStream...
> Hey @fonsdant, are still planning to work on this? Just checking. Hi Lucas! First of all, thanks for the review! Sorry for the delayed response. Yes, I would like...
I have missed removing the references to `transform` on Javadocs too. I will push another commit for it.
I have noticed that `KStreamTransformIntegrationTest.TestTransformer` could be removed as it has become unused.
For now, I have removed the build with deduplicaiton topology test until we decide how to replace the `transform` method inside it.
I have replaced `tranform` with `process` as suggested by docs. I have implemented Processor based on `StandbyTaskEOSMultiRebalanceIntegrationTest.buildWithUniqueIdAssignmentTopology`, but `shouldWipeOutStandbyStateDirectoryIfCheckpointIsMissing` has failed.
I have managed to fix the test! :D
I have removed the references to `transform` from docs. I am wondering if it would be better to replace `transform` with `process`, instead of removing it. I have started to...
I will push some commits, one for each file from which I have removed the transform link, replacing it with process.
I have rebased my branch on trunk and this caused GitHub to close the PR. I am implementing the last review points again.