Popup (on:'click') properly not close when body {height :100%}

[dutrieux]

Bug Report

Popup (on:'click') is not properly close when body=100%

Testcase

https://jsfiddle.net/dutrieux/5wc6123e/

Screenshot

When I set height of body to 'auto', that's work properly (but it's not a good solution, the position with popup doesn't work properly with body:auto;)

the problem is in the hideGracefully function on popup module, the method isInDOM return false in this case. and when body is 100%, in fact the real height is not on overall page :

Version

2.9.2

[sophiajwitt]

Hi! I am working on resolving this issue

[sophiajwitt]

When testing this bug locally, I found that the issue only appears when the window is small enough to require scrolling. In this instance, I have stumbled upon two potential fixes: the first to set body to fit-content in place of 100%, and adjust min-height to 100vh.

When testing this fix method locally, the popup remains unaffected, however this was mentioned to not work using auto, as that affected the popup positioning.

Another fix would be to introduce an additional element that is the size of the entire page that is fixed, and incorporating that element into the hideGracefully function. Either of these fixes are probably best completed locally by the user as they are likely to affect other features within the codebase.

[lubber-de]

Thanks @sophiajwitt for investigation. As both possible solutions are out of the popup module scope (popup should not adjust body), i don't think we can/should implement anything into the FUI Core for that specific situation but rather use your solutions as custom CSS/HTML if needed. @dutrieux Thoughts?