Fomantic-UI icon indicating copy to clipboard operation
Fomantic-UI copied to clipboard

Published 20 hours ago • verified publisher icon fomantic

[list] fix styling of multi-digit ordered lists (#1130)

Open NotWearingPants opened this issue 3 years ago • 6 comments

Description

Fixes styling of multi-digit ordered lists - made the number aligned to the right of the text, so that when more digits are required they will be added on the left and the right edge of the number will stay in place.

I used translateX(-100%) to keep the right edge in a constant position, and adjusted the margin a bit since it previously accounted for the width of the number itself. The number I adjusted it to is to keep the look of numbers with single digits the same.

Testcase

https://jsfiddle.net/futybd2v/

Screenshot

Current (left) vs fixed (right) image

Closes

Fixes #1130

NotWearingPants avatar Oct 23 '21 18:10 NotWearingPants

@NotWearingPants Are you interested in continuation to work on this PR? Please see my review 😉

lubber-de avatar Oct 30 '21 15:10 lubber-de

@lubber-de I am, but finding the time isn't always easy :) I'mma try now

NotWearingPants avatar Oct 31 '21 21:10 NotWearingPants

@NotWearingPants Do you think you can work on this again?

lubber-de avatar Dec 17 '21 15:12 lubber-de

@NotWearingPants Maybe this got forgotten: Do you think you can work on this again? Please see my review

lubber-de avatar May 28 '22 07:05 lubber-de

@lubber-de It's been too long for not replying. Should I take over or would you like to finish with your reviews?

ko2in avatar Oct 10 '23 11:10 ko2in

@lubber-de It's been too long for not replying. Should I take over or would you like to finish with your reviews?

My review was done already, so if you like you can take over

lubber-de avatar Oct 10 '23 11:10 lubber-de