middleman-favicon-maker icon indicating copy to clipboard operation
middleman-favicon-maker copied to clipboard

Published 20 hours ago • verified publisher icon follmann

Updating to v4.0.5 breaks build with wrong template_dir path

Open 5t111111 opened this issue 8 years ago • 2 comments
trafficstars

After updating to v4.0.5, my builds always fail.

I've found the changes in 6a4f8a9554bef044a638815579c18d47ae98c35d break builds when you do not configure template_dir option.

According to the readme, template_dir is optional. However, if it is missed, source_path is set as a default value: https://github.com/follmann/middleman-favicon-maker/blob/d9b87813b17f8942622b7523d829c1d2bd9d9145/lib/middleman-favicon-maker/extension.rb#L13

It makes a template path kind of /Users/yourname/yourproject/Users/username/yourproject/source/_favicon_template.png, and causes No such file or directory error.

I think it is a regression. Can you please consider a fixing soon? I am sure I will send a pull request when I have time though.

5t111111 avatar Aug 25 '17 07:08 5t111111

When you can provide a PR, that would be much appreciated, since I don't use the project actively anymore and have little time right now.

follmann avatar Aug 25 '17 08:08 follmann

@follmann Any news on accepting the PR?

TheE avatar Oct 01 '17 10:10 TheE