which-key.nvim icon indicating copy to clipboard operation
which-key.nvim copied to clipboard

fix(state): defer buffer mappings loading to fix localleader menu

Open niba opened this issue 11 months ago • 15 comments

Description

The which-key menu doesn't appear for localleader in new buffers. Triggering which-key for leader resolves the issue for localleader.

I assume which-key loads buffer mappings before localleader mappings are set. Then, triggering a which-key leader menu updates the state and loads mappings again, but this time all mappings exist.

Deferring the reading of the buffer state fixes this bug.

Related Issue(s)

  • Fixes #476 (still exists)

niba avatar Jan 26 '25 21:01 niba

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Feb 27 '25 02:02 github-actions[bot]

This PR is stale because it has been open 30 days with no activity.

bad bot

disrupted avatar Feb 27 '25 08:02 disrupted

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Mar 30 '25 02:03 github-actions[bot]

bump

RayJameson avatar Mar 30 '25 11:03 RayJameson

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar May 01 '25 02:05 github-actions[bot]

This PR is stale because it has been open 30 days with no activity.

bad bot

disrupted avatar May 01 '25 07:05 disrupted

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Jun 01 '25 02:06 github-actions[bot]

ping

niba avatar Jun 01 '25 05:06 niba

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Jul 03 '25 02:07 github-actions[bot]

bump

niba avatar Jul 03 '25 05:07 niba

@folke I'm sorry for pinging, but do you mind looking at this PR?

RayJameson avatar Jul 03 '25 05:07 RayJameson

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Aug 03 '25 02:08 github-actions[bot]

this is getting tiring

disrupted avatar Aug 04 '25 09:08 disrupted

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Sep 05 '25 02:09 github-actions[bot]

bump

niba avatar Sep 05 '25 06:09 niba