which-key.nvim icon indicating copy to clipboard operation
which-key.nvim copied to clipboard

fix(icons): pattern match should take precedence over plugin

Open minusfive opened this issue 11 months ago • 4 comments

Description

Otherwise all plugin keymaps are forced to use the same icon, can't be granularly customized. This seems to fix a bunch of icons on LazyVim.

E.g. adding an undotree pattern match for Snacks.picker.undo() (#936 😉) is ignored because plugin snacks.nvim was already matched and handled. Thus, all snacks pickers are forced to use the same icon.

Related Issue(s)

N/A

Screenshots

<leader> Before

Screenshot 2025-01-23 at 11 05 51

<leader> After

Screenshot 2025-01-23 at 11 07 07

<leader>g Before

Screenshot 2025-01-23 at 11 06 04

<leader>g After

Screenshot 2025-01-23 at 11 10 59

<leader>s Before

Screenshot 2025-01-23 at 11 05 58

<leader>s After

Screenshot 2025-01-23 at 11 07 12

<leader>f Before

Screenshot 2025-01-23 at 11 06 32

<leader>f After

Screenshot 2025-01-23 at 11 07 17

<leader>u Before

Screenshot 2025-01-23 at 11 06 09

<leader>u After

Screenshot 2025-01-23 at 11 07 22

minusfive avatar Jan 23 '25 16:01 minusfive

@folke if/when you have a chance, mind taking a look at this one?

minusfive avatar Jan 30 '25 00:01 minusfive

Wanted to chime in and say that I was just looking for a solution to this! I was getting annoyed at all the little candy icons in my which-key window as I have maybe 20 different searches with snacks pickers. Adding a bunch of custom rules just to override this (what I may even call a bug) was a chore. Nice PR!

andysazima avatar Mar 06 '25 18:03 andysazima

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Apr 06 '25 02:04 github-actions[bot]

@folke any interest in getting this merged?

I also have #936, #939 and #940 awaiting your review if you'd like to tackle a few at once, they're tiny.

minusfive avatar Sep 20 '25 21:09 minusfive