use vim.keymap.set for keymaps

[budswa]

[max397574]

problem: this is only a latest commit thing on nightly. There is no stable release with it and some people can't even get this version with their package manager

[IndianBoy42]

Does this allow passing lua functions as RHS to which-key? or does which-key do some typechecking that would get in the way of that?

[max397574]

yes it does (I have a fork where I do this)

[zeertzjq]

I don't think this PR changes anything. which-key.nvim already supports Lua functions as RHS, it currently just wraps them to be called from non-Lua mappings, and this PR just adds a redundant extra layer of mapping.

[max397574]

vim.keymap.set is more than justfunction() end it also allows function references

[zeertzjq]

But this PR never passes a function reference to vim.keymap.set(). It only passes a string.

[max397574]

no it can also pass a function reference

[zeertzjq]

It never does this. Have you even read the source code?

https://github.com/folke/which-key.nvim/blob/387fd676d3f9b419d38890820f6e262dc0fadb46/lua/which-key/keys.lua#L212-L219

require('which-key.keys').map() is NOT a public interface. Sure you can call it directly, but what is the point of that?

[max397574]

I have if you pass a function reference then the type wouldn't be function and I just had to disable a type check on my fork and everything worked

[zeertzjq]

Oh, I missed your second comment. This PR doesn't disable the type check though.

[Suyashtnt]

its now on stable! 0.7.0

[jdahm]

@max397574, I saw you're working on this on your fork. Is it ready?

[max397574]

yes ig

[DavidePatria]

Hi @max397574, this pull request does not solve #310 , right?

[folke]

I've pushed an update that utilizes the new api for callbacks and also sets the desc attribute on Neovim 0.7 or higher