fix: ensure that the diagnostic parameters are complete

[0x7a7a]

fix #156

debug

1. The range.start.character field may not exist
2. The range.end field may not exist

log

{                                                                                                                                                                                                                                               
  bufnr = 6,                                                                                                                                                                                                                                    
  col = 12,                                                                                                                                                                                                                                     
  end_col = 27,                                                                                                                                                                                                                                 
  end_lnum = 74,                                                                                                                                                                                                                                
  lnum = 74,                                                                                                                                                                                                                                    
  message = "could use strings.ReplaceAll instead",                                                                                                                                                                                             
  namespace = 25,                                                                                                                                                                                                                               
  range = {                                                                                                                                                                                                                                     
    start = {                                                                                                                                                                                                                                   
      line = 74                                                                                                                                                                                                                                 
    }                                                                                                                                                                                                                                           
  },                                                                                                                                                                                                                                            
  severity = 4,                                                                                                                                                                                                                                 
  source = "QF1004",                                                                                                                                                                                                                            
  user_data = {                                                                                                                                                                                                                                 
    lsp = {}                                                                                                                                                                                                                                    
  }                                                                                                                                                                                                                                             
} 

[0x7a7a]

@folke Can we just change it to:

local start = {
  line = item.col,
  character = item.lnum,
}
local finish = {
  line = item.end_col,
  character = item.end_lnum,
}

Looks the same as the value in range

[ryo33]

This is what I was going to fix. The range field seems to be not defined in Neovim docs and some LSP, e.g. lua-ls, emit diagnostic items with range field but without end field in it.

[folke]

Sorry for the late reply. Thanks!