tokyonight.nvim icon indicating copy to clipboard operation
tokyonight.nvim copied to clipboard
verified publisher icon folke

feat(extra): add active buffer styling for helix

Open archcorsair opened this issue 9 months ago • 12 comments

Description

The helix themes currently lack styling for helix bufferline active tabs, which makes it more difficult to see which current buffer tab is active at a glance.

This PR suggests colors for the tab using the current theme's color pallet.

Screenshots

Day

image

Moon

image

Night

image

Storm

image

archcorsair avatar Mar 04 '25 11:03 archcorsair

I think you have to add this to https://github.com/folke/tokyonight.nvim/blob/main/lua/tokyonight/extra/helix.lua because those extras are generated.

warmwaffles avatar Mar 15 '25 03:03 warmwaffles

I think you have to add this to main/lua/tokyonight/extra/helix.lua because those extras are generated.

Hey, you're awesome and I totally missed that. Fixed now.

PS: Looks like I shouldn't commit the generated files since those get generated by CI. Fixed that too.

archcorsair avatar Mar 15 '25 06:03 archcorsair

I only noticed this because I have been trying to figure out why the ruler is rendered incorrectly (not because of your pr)

warmwaffles avatar Mar 17 '25 02:03 warmwaffles

I only noticed this because I have been trying to figure out why the ruler is rendered incorrectly (not because of your pr)

I've noticed this too. Does the cursor also get hidden by the indent guide for you?

archcorsair avatar Mar 22 '25 02:03 archcorsair

It does. Something is wrong with this theme that is causing that. The themes that ship with helix don't suffer from these issues.

20250313-115121

warmwaffles avatar Mar 22 '25 16:03 warmwaffles

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Apr 22 '25 02:04 github-actions[bot]

Bumping to remove stale tag

archcorsair avatar Apr 22 '25 02:04 archcorsair

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar May 23 '25 02:05 github-actions[bot]

Bumping to remove stale tag

archcorsair avatar May 23 '25 02:05 archcorsair

@archcorsair helix upstream has tokyonight shipped by default now. https://github.com/helix-editor/helix/blob/ae0dd313bdb418b6944ce77b44023c7fb31b9000/runtime/themes/tokyonight_storm.toml

warmwaffles avatar May 23 '25 13:05 warmwaffles

warmwaffles

Thanks for letting me know! Looks like it's still missing bufferline styling though.

archcorsair avatar May 25 '25 20:05 archcorsair

@archcorsair try pushing it up stream, I'm sure other Helix users would like it. I know I would 😄

warmwaffles avatar May 26 '25 19:05 warmwaffles

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Jun 26 '25 02:06 github-actions[bot]