tokyonight.nvim icon indicating copy to clipboard operation
tokyonight.nvim copied to clipboard

bug: day theme has lighter sidebars

Open kassio opened this issue 11 months ago • 5 comments

Did you check docs and existing issues?

  • [X] I have read all the tokyonight.nvim docs
  • [X] I have searched the existing issues of tokyonight.nvim
  • [X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

v0.10.0-dev-2513+g0ffc92649

Operating system/version

MacOS 14.3.1 (23D60)

Describe the bug

My config is giving me a different color set on day from what is shown in the README. My config:

  {
    'folke/tokyonight.nvim',
    lazy = false,
    priority = 1000,
    config = function()
      require('tokyonight').setup({
        style = 'night',
        light_style = 'day',
        terminal_colors = true,
        sidebars = { 'qf', 'help', 'terminal' },
        day_brightness = 0.3,
      })

      vim.cmd.colorscheme('tokyonight')
    end,
  }
readme image my config
orig

Am I doing something wrong?

Steps To Reproduce

detailed above

Expected Behavior

detailed above

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  {
    'folke/tokyonight.nvim',
    lazy = false,
    priority = 1000,
    config = function()
      require('tokyonight').setup({
        style = 'night',
        light_style = 'day',
        terminal_colors = true,
        sidebars = { 'qf', 'help', 'terminal' },
        day_brightness = 0.3,
      })

      vim.cmd.colorscheme('tokyonight')
    end,
  },
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

kassio avatar Mar 05 '24 19:03 kassio

I have exactly the same problem. Other types of buffers defined as sidebars, like help and the quickfix list, are also lighter.

denisw avatar Mar 27 '24 10:03 denisw

It seems that the light theme is not very used, so this wasn't noticed for a while. :/

kassio avatar Mar 27 '24 23:03 kassio

I thought this could be due to my wezterm config, but I think I'm using the right themes:

if wezterm.gui.get_appearance():find('Dark') then
  config.color_scheme = 'tokyonight_night'
else
  config.color_scheme = 'tokyonight_day'
end

And from wezterm docs:

Author: folke
Source: https://github.com/folke/tokyonight.nvim
This scheme is also known as tokyonight-day.

To use this scheme, add this to your config:


config.color_scheme = 'tokyonight_day'

# ...

Author: folke
Source: https://github.com/folke/tokyonight.nvim
This scheme is also known as tokyonight.

To use this scheme, add this to your config:


config.color_scheme = 'tokyonight_night'

kassio avatar Apr 02 '24 02:04 kassio

Hacky solution:

require('tokyonight').setup({
  style = 'storm',
  light_style = 'day',
  on_colors = function(colors)
    local bg_dark = colors.bg
    local bg = colors.bg_sidebar
    colors.bg = bg
    colors.bg_sidebar = bg_dark
  end
})

\cc @denisw @folke

kassio avatar May 10 '24 13:05 kassio

@kassio your solution worked!

audendana avatar May 16 '24 03:05 audendana

Fixed

folke avatar Jul 02 '24 12:07 folke