tokyonight.nvim icon indicating copy to clipboard operation
tokyonight.nvim copied to clipboard

bug: helix themes are broken missing attribute declarations

Open blakedietz opened this issue 1 year ago • 1 comments

Did you check docs and existing issues?

  • [X] I have read all the tokyonight.nvim docs
  • [X] I have searched the existing issues of tokyonight.nvim
  • [X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.10.0-dev-2066+g1813661a6-Homebrew

Operating system/version

macOS 14.2.1

Describe the bug

This is specific to helix. Themes that are completely missing attribute definitions as of https://github.com/folke/tokyonight.nvim/commit/9c5ef1e69ad2bd73b4ebe945e7e02284f2658743#diff-7d0281c0678c4322e968c0aaba8a155200ffce96cc30be6005b66e6f536707ccR25

Steps To Reproduce

Copy any of the generated themes for helix and attempt to set them. They do nothing. Go to the very first commit and use the files that were generated there and notice that they work.

Expected Behavior

The themes are applied.

Repro

Look at the commit here: https://github.com/folke/tokyonight.nvim/commit/9c5ef1e69ad2bd73b4ebe945e7e02284f2658743#diff-7d0281c0678c4322e968c0aaba8a155200ffce96cc30be6005b66e6f536707ccL25

blakedietz avatar Feb 03 '24 21:02 blakedietz

Looks like this commit might be the culprit. https://github.com/folke/tokyonight.nvim/commit/2e00d06319072953b54b0316146151d31e71680c

blakedietz avatar Feb 03 '24 21:02 blakedietz

Fixed by a PR I merged

folke avatar Jul 02 '24 13:07 folke