snacks.nvim icon indicating copy to clipboard operation
snacks.nvim copied to clipboard

fix(words,zen): migrate to client:supports_method for deprecation

Open MuntasirSZN opened this issue 8 months ago • 5 comments

Description

Fixes deprecations by neovim 0.11.

Related Issue(s)

Screenshots

MuntasirSZN avatar Apr 11 '25 14:04 MuntasirSZN

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar May 12 '25 02:05 github-actions[bot]

Nope/

MuntasirSZN avatar May 12 '25 04:05 MuntasirSZN

This will cause problems in Neovim <0.11. I don't know if Folke wants to drop support for that, but it would be better to add conditional which checks Neovim version and uses one accordingly. The old mehod is deprecated, but still resolved internally in Neovim until its removal on 0.13. It only shows the deprecated message.

dpetka2001 avatar May 12 '25 06:05 dpetka2001

I can write a wrapper function that handles it, but then we need to wrap client with that function, which will become ugly. @dpetka2001

MuntasirSZN avatar May 12 '25 10:05 MuntasirSZN

I don't know how Folke wants to handle it with regards to dropping support on Neovim <0.11. That is his decision. All I know is this is not going to work on Neovim <0.11, whereas if you leave it as is both versions will work and only the deprecation message will show or a wrapper.

Best to wait for his feedback.

dpetka2001 avatar May 12 '25 10:05 dpetka2001

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Jun 12 '25 02:06 github-actions[bot]

Nope

MuntasirSZN avatar Jun 12 '25 04:06 MuntasirSZN

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Jul 30 '25 02:07 github-actions[bot]

Nope

MuntasirSZN avatar Jul 30 '25 06:07 MuntasirSZN

This PR is stale because it has been open 30 days with no activity.

github-actions[bot] avatar Sep 01 '25 02:09 github-actions[bot]

Nope, just @folke not around.

MuntasirSZN avatar Sep 01 '25 02:09 MuntasirSZN