noice.nvim icon indicating copy to clipboard operation
noice.nvim copied to clipboard

Published 20 hours ago • verified publisher icon folke

<80>kb character in notifications

Open pBorak opened this issue 2 years ago • 7 comments

Describe the bug

Hey, I've noticed that this changes introduced weird behavior when interacting with vim-fugitive. After doing a git commit within the nvim with the use of vim-fugitive there's an extra <80>kb character present in the notification. See screenshots below

To Reproduce Steps to reproduce the behavior:

  1. Open fugitive popup
  2. Stage files
  3. hit cc to open the commit window
  4. write commit-msg and hit wq

Expected Behavior There's no <80kb>

Screenshots Screenshot 2022-10-26 at 22 01 46

Before 8463b0 it looked this way Screenshot 2022-10-26 at 22 00 44

pBorak avatar Oct 26 '22 20:10 pBorak

@folke , can't seem to figure out why issue #142, here, and this one kind of have some sort of problem something in common. I've been facing the same problem too whereby the [SHIFT] key seems to be already pressed then a notification appears whenever the key is actually pressed showing what would have been the result of [SHIFT + ,] which is [<] as illustrated below. Note: No one pressed the [SHIFT] key, just the [,] key which in itself I mapped it to saving a file(wasn't really using it for [?] search next :-)

image

Pheon-Dev avatar Oct 27 '22 20:10 Pheon-Dev

👍🏻 I have also noticed the issue with < notifications

pBorak avatar Oct 27 '22 20:10 pBorak

Check :h shortmess. t option. Standard Neovim behavior

image

folke avatar Oct 27 '22 21:10 folke

@Pheon-Dev #142 is an nvin-notify problem, not Noice. Your issue #99, is not an issue at all. Your issue #99 was because of a plugin. All unrelated to this.

This is likely caused by my hack to make keys work in cmdline during substitute. But haven't yet found anything that could cause that.

folke avatar Oct 27 '22 21:10 folke

Just looked it up and <80>kb is indeed the internal code for <backspace>. Which I do here https://github.com/folke/noice.nvim/blob/ac29174bebeedb86983eea7436dabcf2b17dbc19/lua/noice/util/hacks.lua#L255

folke avatar Oct 27 '22 21:10 folke

Thanks for the explanation, it makes more sense now. I'll try to config my nvim-notify a bit better to avoid receiving unnecessary messages

Pheon-Dev avatar Oct 28 '22 04:10 Pheon-Dev

Once the upstream issue below is solved, this issue can be solved

  • [ ] https://github.com/neovim/neovim/issues/20463

folke avatar Oct 29 '22 08:10 folke

I was able to work around the cursor issue by calling update_screen through ffi, so your issue should no longer happen

folke avatar Nov 16 '22 20:11 folke