flash.nvim icon indicating copy to clipboard operation
flash.nvim copied to clipboard

bug: dot-repeat breaks for `dt/df` motions when moving lines if `multi_line` is false

Open norbertkeri opened this issue 1 year ago • 3 comments

Did you check docs and existing issues?

  • [X] I have read all the flash.nvim docs
  • [X] I have searched the existing issues of flash.nvim
  • [X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.9.1

Operating system/version

Arch linux

Describe the bug

If you disable multi_line, the dot operator will do nothing after dt/df motions. If you don't disable it, the dot operator works fine.

What's also sightly interesting is that you will have to press "u" 2 times to correctly undo the deletion, I assume the bug also causes an incorrect undo entry.

Steps To Reproduce

            require("flash").setup({
                modes = {
                    char = {
                        multi_line = false,
                    }
                }
            })

And you have the following text, where | is the cursor:

-- |foo,bar,baz
-- foo,bar,baz

Press df,j.

Expected Behavior

-- bar,baz
-- |bar,baz

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
    vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
    vim.fn.system({
	"git",
	"clone",
	"--filter=blob:none",
	"https://github.com/folke/lazy.nvim.git",
	lazypath,
    })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
    "folke/tokyonight.nvim",
    { "folke/flash.nvim", opts = {
	modes = {
	    char = {
		multi_line = false
	    }
	}
    }
},
-- add any other plugins here
}
require("lazy").setup(plugins, {
    root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")

-- foo,bar,baz
-- foo,bar,baz

norbertkeri avatar Jul 31 '23 11:07 norbertkeri

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jul 06 '24 01:07 github-actions[bot]

The bug is still present but I'm ok with closing

norbertkeri avatar Jul 06 '24 16:07 norbertkeri

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Aug 07 '24 01:08 github-actions[bot]

This issue was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Aug 14 '24 01:08 github-actions[bot]