folbricht
Prefetch feature
@folbricht I think it should be all good for you to review again. I would like you to review it in draft before I add it to full PR because I would like it to run on my servers as a test as well
I haven't had time to go through it fully yet. But noticed at least one race condition. Also there seem to be unrelated changes in this PR. A bunch of files are now empty, GH workflows deleted, and
.ideafiles added. Was any of that intentional?
Not at all. that was due to a rebase issue
Tried to fiddle around with this, but I do not see anything prefetched. Is there some kind of logging I can check for?
Tried to fiddle around with this, but I do not see anything prefetched. Is there some kind of logging I can check for?
Because my dumb a** forgot to add a dns.msg to the query prefetch request so they were all nil. :/
This has since been fixed
Tried to fiddle around with this, but I do not see anything prefetched. Is there some kind of logging I can check for?
Because my dumb a** forgot to add a
dns.msgto the query prefetch request so they were allnil. :/ This has since been fixed
No worries :-). Will give it a try again later.
Have you considered moving this feature into the existing cache? Since there's only a couple config flags this should be quite straightforward. I can give this try if you like.
Also, the PR now contains a whole bunch of permission changes which makes this quite hard to read.
Have you considered moving this feature into the existing cache? Since there's only a couple config flags this should be quite straightforward. I can give this try if you like.
Also, the PR now contains a whole bunch of permission changes which makes this quite hard to read.
I was thinking that originally. Sorry that on the permissions changes WSL and Windows caused that because I was building on WSL and committing on Windows which for some really odd reason was changing the permissions. I am ok with you doing adding it to the cache function
If you don't mind, I'd like to take your branch and try to merge the prefetch into the existing cache. It might make it easier to use, definitely going to use your changes and just shuffle them around a bit and see if it works.
Np! And if you don't have time just let me know I can do it myself. I would like to see this feature in master that's why I say that
configuration There is no introduction to this feature .https://github.com/folbricht/routedns/blob/master/doc/configuration.md#Static-responder
There's an similar feature being tested on https://github.com/folbricht/routedns/tree/prefetch-3 at the moment (it's still draft so no docs there either).