rubocop-daemon icon indicating copy to clipboard operation
rubocop-daemon copied to clipboard

Add a option to expose daemon's TCP port

Open cumet04 opened this issue 4 years ago • 2 comments

The gem's idea is great, but it can't be used from remote environments (for example, from docker), because it can't expose TCP port.

This pull-request is to add a option for exposing TCP port to external. I suppose that, rubocop-daemon run as docker container and user use rubocop-daemon-wrapper on host machine.

The option name, --binding, is from same feature of rails new. But I'm not particular about the option name, so it's ok to rename it.

cumet04 avatar Dec 31 '20 07:12 cumet04

FIY, the usecase's article is here (Japanese only): https://zenn.dev/cumet04/articles/fast-rubocop-on-docker

cumet04 avatar Dec 31 '20 08:12 cumet04

I tested it and it perfectly working!

brunofrank avatar Apr 17 '21 22:04 brunofrank