fog-google

fog-google copied to clipboard

Ambiguity in asynchronous execution setting

13

While figuring out acceptance tests for vagrant-google, I found a weird logic piece in the implementation of synchronous operations in Fog. As an example, let's take a look at Server...

Temikus

Some save() methods have arguments and shouldn't

1

File is probably fine but user/server should _not_ have them ``` λ grep -R 'def save([a-z ]' . ./lib/fog/google/models/sql/user.rb: def save(password: nil) ./lib/fog/storage/google_xml/models/file.rb: def save(options = {}) ./lib/fog/compute/google/models/server.rb: def save(username:...

Temikus

Server.image_name should actually return a name, not a self-link

1

`image_name` should actually return a name, not a self-link https://github.com/fog/fog-google/blob/3741053202f7c856fbe9fa5ed715bd213f48e236/lib/fog/compute/google/models/server.rb#L182-L200

Temikus

Requests should return `Fog::Compute::Google::Operation`

1

Currently requests return an API operation, i.e.: `Google::Apis::ComputeV1::Operation:` And then usually get parsed by model like so: ``` operation = Fog::Compute::Google::Operations.new(:service => service) .get(data.name) ``` That's a lot of duplicate...

Temikus

Get rid of "name eq .*#{identity}" logic

3

So, if I'm reading it right the "name eq .*#{identity}" logic is not needed anymore. I'm talking about the "Servers" for example: https://github.com/fog/fog-google/blob/8780575ea089e75b8628565ec6f112e5e850b419/lib/fog/compute/google/models/servers.rb#L34-L38 I think we shouldn't append the `.*`...

Temikus

TargetPool.get_health should return better output

1

Currently: ``` target_pool.get_health(server.name) => {"https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-1-testtargetpools-test-get-health"=> [{:health_state=>"UNHEALTHY", :instance=>"https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-1-testtargetpools-test-get-health"}]} ``` or without parameters ``` target_pool.get_health() => {"https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-1-testtargetpools-test-get-health"=> [{:health_state=>"UNHEALTHY", :instance=>"https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-1-testtargetpools-test-get-health"}], "https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-2-testtargetpools-test-get-health"=>[]} ``` Ideally this should just return state: - HEALTHY - UNHEALTHY -...

Temikus

Add a `project` method to Images

6

See: ``` # This attribute is not available in the representation of an # 'image' returned by the GCE server (see GCE API). However, # images are a global resource...

Temikus

@icco, @Temikus and @plribeiro3000

militarpancho

Updates the requirements on [fog-core](https://github.com/fog/fog-core) to permit the latest version. Changelog Sourced from fog-core's changelog. 2.6.0 10/24/2024 bump to excon ~> 1.0 2.5.0 08/02/2024 drop spec files from gem package...

dependabot[bot]

This pull request updates the `*.gemspec` file to optimize the gem package size and structure. The changes include: - Modified `files` to exclude test files from the package. - Removed...

f440