fog-aws icon indicating copy to clipboard operation
fog-aws copied to clipboard

add concurrency to multipart_save method

Open avoidik opened this issue 9 months ago • 4 comments

my (naive) attempt to fix https://github.com/fog/fog-aws/issues/738 and https://github.com/fog/fog-aws/issues/737

avoidik avatar May 13 '25 20:05 avoidik

@avoidik - This seems like a pretty reasonable next step to try to me. Have you had a chance to test it? Were there additional parts you wanted to change before we proceed?

geemus avatar May 19 '25 14:05 geemus

@avoidik - also, the head error appears to be on main and unrelated to this, I'll see about addressing that separately.

geemus avatar May 19 '25 14:05 geemus

@geemus I didn't test it thoroughly, I could run yet another performance benchmark again after your minimal input and some kind of a review

avoidik avatar May 19 '25 14:05 avoidik

@avoidik Yeah, that sounds good. Overall this code appears to align well with the copy code that was already here, but I don't have direct experience using that either. It will also be helpful to know if and how much it helps with the performance issues you originally noted. Thanks!

geemus avatar May 19 '25 14:05 geemus