cog-comfyui icon indicating copy to clipboard operation
cog-comfyui copied to clipboard

Add support for custom lora urls in LoRA Stacker

Open guivr opened this issue 11 months ago • 9 comments

Fixes #244

guivr avatar Jan 20 '25 10:01 guivr

Update: now it hashes filenames and only download .safetensors files

guivr avatar Jan 28 '25 11:01 guivr

Is there anything I need to work on to get this approved? @fofr

I need this to use it in my business (currently using a custom cog)

Thanks

guivr avatar Jan 30 '25 10:01 guivr

I tried to improve the code + keep the original filename in the beginning of the final filename so that the logs from WeightsDownloader are easier to read and identify which lora it is downloading.

guivr avatar Feb 01 '25 08:02 guivr

@fofr what do I need to do?

guivr avatar Feb 13 '25 09:02 guivr

@fofr Hi fofr, you said you’d fix this (#237)

how do you suggest fixing it if not this way?

guivr avatar Feb 19 '25 16:02 guivr

any feedback?

guivr avatar Mar 09 '25 12:03 guivr

@fofr what's missing for this to get approved? Why are there no responses? What's wrong with it?

guivr avatar Apr 09 '25 11:04 guivr

@guivr Can you push to your own fork if you need this urgently?

jordancoult avatar Apr 09 '25 17:04 jordancoult

@guivr Can you push to your own fork if you need this urgently?

Yes it's possible but then I have to use my own cog, and it always gets cold/sleeps. any-comfyui is usually warm and starts up faster (less costs)

I think this update is beneficial to everyone because the LoRA Stacker is a node listed as supported by this cog, but it's not fully supported - because it can't load custom LoRA URLs - but this pull request fixes it.

guivr avatar Apr 10 '25 01:04 guivr