starknet.dart icon indicating copy to clipboard operation
starknet.dart copied to clipboard

CI: Update devnet to 0.3.0

Open ptisserand opened this issue 10 months ago • 5 comments

Is your feature request related to a problem? Please describe. CI is currently using devnet 0.1.2 for testing purpose, we should upgrade to version 0.3.0 to ensure RPC version 0.8 is correctly handle

Describe the solution you'd like Upgrade devnet to 0.3.0

Expected results

  • CI is using devnet 0.3.0
  • All tests passed
  • All devnet related constants are updated: account classhash, predeployed account adresses, predeployed account private keys, classhash after declare ...
  • Documentation is updated

ptisserand avatar Feb 05 '25 10:02 ptisserand

I'd like to take this issue.

Hi, I have updated the issue description to add more details. If you still want to apply, do you have an ETA for this issue ?

ptisserand avatar Feb 19 '25 08:02 ptisserand

Is it okay if I take this?

pheobeayo avatar Apr 24 '25 19:04 pheobeayo

I'd love to give this a go.

ritik4ever avatar Apr 26 '25 11:04 ritik4ever

Hi @pheobeayo are you still working on it ?

ptisserand avatar May 17 '25 08:05 ptisserand

Hi @pheobeayo are you still working on it ?

Yes please

pheobeayo avatar May 17 '25 09:05 pheobeayo

i will like to work on this. ETA: 24 hours

Sendi0011 avatar Jun 30 '25 20:06 Sendi0011

Hi @Sendi0011 any update on this ?

ptisserand avatar Jul 08 '25 06:07 ptisserand

Hi @ptisserand sorry for the delays, i`ve been down lately. but i will get this done hopefully by tomorrow. sorry for the inconveniences this has caused.

Sendi0011 avatar Jul 08 '25 19:07 Sendi0011

Hi @ptisserand sorry for the delays, i`ve been down lately. but i will get this done hopefully by tomorrow. sorry for the inconveniences this has caused.

Hi @Sendi0011 any update on this ?

ptisserand avatar Jul 17 '25 08:07 ptisserand

Working on it. I’ll a open a PR soon

On Thu, 17 Jul 2025 at 9:05 AM, ptisserand @.***> wrote:

ptisserand left a comment (focustree/starknet.dart#446) https://github.com/focustree/starknet.dart/issues/446#issuecomment-3083052657

Hi @ptisserand https://github.com/ptisserand sorry for the delays, i`ve been down lately. but i will get this done hopefully by tomorrow. sorry for the inconveniences this has caused.

Hi @Sendi0011 https://github.com/Sendi0011 any update on this ?

— Reply to this email directly, view it on GitHub https://github.com/focustree/starknet.dart/issues/446#issuecomment-3083052657, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJ37K2DACJSL4NL3E52534L3I5KLTAVCNFSM6AAAAABWQWJAUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOBTGA2TENRVG4 . You are receiving this because you were mentioned.Message ID: @.***>

Sendi0011 avatar Jul 17 '25 10:07 Sendi0011

Hi @Sendi0011, you have been assigned to this issue 3 weeks ago and your ETA was 24 hours...

With the new ODweek starting tomorrow, if there is no PR tomorrow I will unassigned you.

ptisserand avatar Jul 21 '25 13:07 ptisserand

Good day @ptisserand i'm really sorry for the delay and inconveniences this caused, i never had the intentions to delay the work just had alot going on, also needed to cross check the work before opening a PR but it's done right now. Sorry for all the delay, I promise it won't happen again.

Sendi0011 avatar Jul 21 '25 22:07 Sendi0011

Hi @Sendi0011 I have looked at your PR and I think there is a misunderstanding about this issue. The goal is to use starknet-devnet 0.4.2 for the CI but with your modifications, starknet-devnet is no more running: see https://github.com/focustree/starknet.dart/actions/runs/16429080443/job/46427707762?pr=548#step:10:78

Are you comfortable with how to debug github CI ?

ptisserand avatar Jul 21 '25 23:07 ptisserand

Good day sir, I'm trying to get that fixed on my local machine. I'll keep you updated

On Tue, 22 Jul 2025 at 12:28 AM, ptisserand @.***> wrote:

ptisserand left a comment (focustree/starknet.dart#446) https://github.com/focustree/starknet.dart/issues/446#issuecomment-3099905703

Hi @Sendi0011 https://github.com/Sendi0011 I have looked at your PR and I think there is a misunderstanding about this issue. The goal is to use starknet-devnet 0.4.2 for the CI but with your modifications, starknet-devnet is no more running: see https://github.com/focustree/starknet.dart/actions/runs/16429080443/job/46427707762?pr=548#step:10:78

Are you comfortable with how to debug github CI ?

— Reply to this email directly, view it on GitHub https://github.com/focustree/starknet.dart/issues/446#issuecomment-3099905703, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJ37K2E55RWHYLICBMB5L6L3JVZTDAVCNFSM6AAAAABWQWJAUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOJZHEYDKNZQGM . You are receiving this because you were mentioned.Message ID: @.***>

Sendi0011 avatar Jul 21 '25 23:07 Sendi0011

Good day sir, I'm trying to get that fixed on my local machine. I'll keep you updated

Do you mean that you create your PR without testing on your side ?

ptisserand avatar Jul 23 '25 03:07 ptisserand

Testing it here initially, it passed but getting a different result now

On Wed, 23 Jul 2025 at 4:53 AM, ptisserand @.***> wrote:

ptisserand left a comment (focustree/starknet.dart#446) https://github.com/focustree/starknet.dart/issues/446#issuecomment-3105580990

Good day sir, I'm trying to get that fixed on my local machine. I'll keep you updated … <#m_1546630183287874505_>

Do you mean that you create your PR without testing on your side ?

— Reply to this email directly, view it on GitHub https://github.com/focustree/starknet.dart/issues/446#issuecomment-3105580990, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJ37K2AKAUEW7CMMI65PB7T3J4BMHAVCNFSM6AAAAABWQWJAUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMBVGU4DAOJZGA . You are receiving this because you were mentioned.Message ID: @.***>

Sendi0011 avatar Jul 23 '25 06:07 Sendi0011

Hi @Sendi0011 are you still working on this issue ?

ptisserand avatar Jul 28 '25 06:07 ptisserand

@ptisserand good morning sir, I’m finding small issues trying to get it fixed, plus my machine has been lagging for a while now. I don’t know if it can be unassigned from me in order not keep you waiting on it. So sorry for the delays

Sendi0011 avatar Jul 28 '25 07:07 Sendi0011

Hi @ptisserand , may i take this issue?

rukafe0x avatar Aug 07 '25 16:08 rukafe0x

Closed by #558

ptisserand avatar Aug 27 '25 15:08 ptisserand