jollyday icon indicating copy to clipboard operation
jollyday copied to clipboard

Aggregate sonar coverage

Open derTobsch opened this issue 1 year ago • 8 comments

refs #419

atm we do not track jackson, so we will provide a report aggregate module that will cover all modules for us.

derTobsch avatar Jan 12 '24 13:01 derTobsch

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jan 15 '24 09:01 sonarqubecloud[bot]

Will this also fix the never ending failing actions in forks, e.g. https://github.com/XSpielinbox/jollyday/actions or what does one have to do there to fix this?

XSpielinbox avatar Feb 01 '24 17:02 XSpielinbox

Will this also fix the never ending failing actions in forks, e.g. https://github.com/XSpielinbox/jollyday/actions or what does one have to do there to fix this?

No this does not fix your problem. Your problem is that no sonar token is provided and therefore it cannot run sonar.

This will fix that all module reports will be aggregated. But I need to think about a good testing modularity, so that I do not need to write duplicated tests.

derTobsch avatar Feb 01 '24 18:02 derTobsch

No this does not fix your problem. Your problem is that no sonar token is provided and therefore it cannot run sonar.

Ah, ok. Is there a possibility to disable these sonar test in forks as I don't see an option to provide a sonar without having an account there?

XSpielinbox avatar Feb 01 '24 18:02 XSpielinbox

No this does not fix your problem. Your problem is that no sonar token is provided and therefore it cannot run sonar.

Ah, ok. Is there a possibility to disable these sonar test as I don't see an option to provide a sonar without having an account there?

yes of course. I will look into it.

derTobsch avatar Feb 02 '24 12:02 derTobsch

@XSpielinbox see https://github.com/focus-shift/jollyday/pull/448 please test it :)

derTobsch avatar Feb 02 '24 12:02 derTobsch

@XSpielinbox see #448 please test it :)

Yes, it works now! Thank you!

XSpielinbox avatar Feb 02 '24 12:02 XSpielinbox