fn icon indicating copy to clipboard operation
fn copied to clipboard

Add support for plugins in fnext

Open riconnon opened this issue 5 years ago • 3 comments

  • What I did

Preliminary support for dynamically loadable extensions. Doesn't (yet) include ability to specify loading them at runtime.

  • How I did it

Uses golang "plugins" to load plugins from shared libraries

  • How to verify it

Good question... I've verified it myself using my extensions but maybe we should have some automated tests with dummy plugins.

  • One line description for the changelog

Add support for dynamically loading extensions

  • One moving picture involving robots (not mandatory but encouraged)

Robot

riconnon avatar Jan 22 '19 08:01 riconnon

i'm 'with the program' on moving call overrider to fnext, short of getting rid of it altogether. i do think that we should probably avoid adding the .so plugin stuff however and just have the package using the call overrider bake it in at compile time like all the other plugins in fnext - i appreciate trying it out, it's something we've been curious about for a while, but there is not strong buy in from what i can tell at this time anyway (we could have a wider discussion, of course...) and we'd need deployment tools to manage that among other things.

rdallman avatar Jan 24 '19 02:01 rdallman

I would also prefer to see CallOverrider removed altogether. My initial thinking was that if the "exts" map that it handles was moved to the call object then this would just be a CallListener Happy to go through and do that work instead if it's preferred.

riconnon avatar Jan 24 '19 11:01 riconnon

My initial thinking was that if the "exts" map that it handles was moved to the call object then this would just be a CallListener

it's early, but that sounds like a great idea to me

rdallman avatar Jan 24 '19 17:01 rdallman