fdk-python icon indicating copy to clipboard operation
fdk-python copied to clipboard

fix release script to push version tags in correct format

Open roroco opened this issue 6 years ago • 4 comments

This fixes the tag format being pushed by the release script to match the current convention, i.e. tags are in the format vX.X.X

roroco avatar Oct 11 '19 18:10 roroco

Okay, so, we got back to a free plan, shame. There are two things that must be fixed:

  • get rid of caching in CI config (relatively easy)
  • fix deploy keys as the CI is not capable to publish artefacts to the PYPI.

denismakogon avatar Oct 11 '19 18:10 denismakogon

I’ll take of the first thing, updating the ci config

On Fri, Oct 11, 2019 at 11:59 AM Denis Makogon [email protected] wrote:

Okay, so, we got back to a free plan, shame. There are two things that must be fixed:

  • get rid of caching in CI config (relatively easy)
  • fix deploy keys as the CI is not capable to publish artefacts to the PYPI.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fnproject/fdk-python/pull/101?email_source=notifications&email_token=AMIAMV22H6FP6XFQ5LRFWCLQODEHHA5CNFSM4I745TC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBA5G6Y#issuecomment-541184891, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMIAMVZJADKBFJPU34VUGG3QODEHHANCNFSM4I745TCQ .

roroco avatar Oct 11 '19 19:10 roroco

Without fixing deploy keys this script would have no effect, sorry.

On Fri, 11 Oct 2019 at 22:37, Rohit Kumar [email protected] wrote:

I’ll take of the first thing, updating the ci config

On Fri, Oct 11, 2019 at 11:59 AM Denis Makogon [email protected] wrote:

Okay, so, we got back to a free plan, shame. There are two things that must be fixed:

  • get rid of caching in CI config (relatively easy)
  • fix deploy keys as the CI is not capable to publish artefacts to the PYPI.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/fnproject/fdk-python/pull/101?email_source=notifications&email_token=AMIAMV22H6FP6XFQ5LRFWCLQODEHHA5CNFSM4I745TC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBA5G6Y#issuecomment-541184891 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AMIAMVZJADKBFJPU34VUGG3QODEHHANCNFSM4I745TCQ

.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/fnproject/fdk-python/pull/101?email_source=notifications&email_token=AAXEX24VFTJZ4RSOZNSCXL3QODIYFA5CNFSM4I745TC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBBAGNQ#issuecomment-541197110, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXEX25HXJH3KMX7F7PWPK3QODIYFANCNFSM4I745TCQ .

denismakogon avatar Oct 11 '19 21:10 denismakogon

can you provide more details on the deploy keys? I am not that familiar with how Circle CI and twine interact with pypi.

roroco avatar Oct 11 '19 21:10 roroco