cli icon indicating copy to clipboard operation
cli copied to clipboard

fn update context allows arbitrary keys

Open jlbutler opened this issue 5 years ago • 1 comments

Arbitrary keys may be added to a context via 'fn update context'. This may or may not be as intended, but it adds cruft where a use case is hard to discern. Possibly the call should check for the list of used / valid keys.

jlbutler avatar Sep 27 '18 17:09 jlbutler

The namespace of available/valid keys really depends on the full range of context providers (admittedly only two at the moment) and then where do you go if you start validating keys to fn update context - do we start validating the context files? I get the point about cruft but invalid values just get ignored but I think we have bigger fish to fry.

rikgibson avatar Oct 18 '18 15:10 rikgibson