cli icon indicating copy to clipboard operation
cli copied to clipboard

fn deploy -v is confusing

Open zootalures opened this issue 6 years ago • 4 comments

Verbose is confusing/broken - it seems there are two flags - one on "fn " one on "fn build" and only the former works

Expectation

 fn  deploy  --app test   --verbose 
<verbose output>

actual :

fn  deploy  --app test   --verbose 
<terse output> 

what actually works

fn --verbose   deploy  --app test   

zootalures avatar Feb 14 '18 16:02 zootalures

I'd rather verbose works in both positions and in the same way

zootalures avatar Feb 14 '18 16:02 zootalures

+1 -- i brought this up somewhere... thought it was an issue already. @rdallman pointed out that it's a 3rd party lib that needs modified/fixed to support this.

carimura avatar Feb 14 '18 18:02 carimura

our cli package is doing a global flag set for verbose mode and due to the shortcomings of the go flag package which it uses (iirc) forces this to be directly after the binary arg. changing cli packages isn't very fun, we should probably just deal with the hassle of not using a global flag and having to litter the -v flag over commands that want it

rdallman avatar Feb 14 '18 19:02 rdallman

Note, if this does change, then the test harness also needs to be modified following https://github.com/fnproject/cli/pull/305 as that is using the global flag.

msgodf avatar Jun 06 '18 14:06 msgodf