footsteps-app icon indicating copy to clipboard operation
footsteps-app copied to clipboard

Published 20 hours ago • verified publisher icon fnplus

Add Style Guide for Best Practices, Coding Guidelines

Open xlogix opened this issue 4 years ago • 8 comments

xlogix avatar Mar 01 '20 03:03 xlogix

I am interested in this issue. Can you @xlogix tell me more specific description about what I have to do and what expected to be? Thanks!

huonggiangbui avatar Mar 01 '20 05:03 huonggiangbui

@huonggiangbui We want to add issue templates, PR templates & style guides for the code. Check out Oppia project for reference. https://github.com/oppia/oppia/

xlogix avatar Mar 01 '20 05:03 xlogix

@xlogix

I have added the react style guide in the Wiki Page.

People can follow that to write better code into React. Below is the link as well.

https://github.com/airbnb/javascript/tree/master/react

tarun-nagpal-github avatar Mar 02 '20 07:03 tarun-nagpal-github

Hey Tarun, thanks for linking the guidelines but I think we should directly add a page with the guidelines and add a source link at the bottom.

Also, did you take a look at issue templates? Or Pull request templates? We could add those too

xlogix avatar Mar 02 '20 07:03 xlogix

Sure @xlogix , I will create a page for the guidelines.

I am working on the other two.

tarun-nagpal-github avatar Mar 03 '20 09:03 tarun-nagpal-github

Is this issue assigned to someone, or can I work on it?

suntwalriya avatar Mar 08 '20 11:03 suntwalriya

@carrisunrio Go ahead!

xlogix avatar Mar 08 '20 15:03 xlogix

@xlogix @carrisunrio

I have added the WIKI page for "React Style guide and best practices"

https://github.com/fnplus/footsteps-app/wiki/React---Style-guide-and-best-practices

tarun-nagpal-github avatar Mar 13 '20 12:03 tarun-nagpal-github