alfred-pocket icon indicating copy to clipboard operation
alfred-pocket copied to clipboard

Published 20 hours ago • verified publisher icon fniephaus

Port to Python 3

Open xilopaint opened this issue 2 years ago • 8 comments

xilopaint avatar Jun 09 '22 14:06 xilopaint

Thanks for the PR. It looks like this replaces alfred-workflow with alpynist and I'm not familiar with it. If someone from the AlfredApp community could provide an update on how workflows handle Python 3 support these days, that'd be great. Also, it'd be great if someone could give this a go and help reviewing. I still have a Python 2 installation on my MacBook.

fniephaus avatar Jun 24 '22 12:06 fniephaus

I took a look at the PR and it read ok to me. Successful install and usage with Alfred 5.0.1 and Python 3.9, no py2 installed. The tests failed until the version file is read in text mode as suggested above.

cdw avatar Aug 18 '22 18:08 cdw

The issue was already fixed in the latest version of Alpynist. I just pushed it.

xilopaint avatar Aug 18 '22 18:08 xilopaint

@xilopaint Any updates on merging this PR?

devnoname120 avatar May 29 '23 13:05 devnoname120

@xilopaint Any updates on merging this PR?

You should ask @fniephaus, I'm only the PR author.

xilopaint avatar May 30 '23 04:05 xilopaint

@devnoname120 Have you tested this PR? I haven't had the time to do so and I'd like to collect some feedback before merging a full rewrite.

fniephaus avatar May 30 '23 06:05 fniephaus

@fniephaus Yes I can confirm that it works. I tested 96169ad on Alfred 5.1.

The only awkward part is that the workflow asked me twice to authorize with an error in the middle In Alfred:

  1. I typed Pocket in Alfred's bar and authorized it in the web page that opened.
  2. I typed again Pocket in Alfred's bar but this time it displayed an error. I don't have a screenshot or a log but in the bar it displayed Error without any further details.
  3. I typed again Pocket in Alfred's bar and authorized it again in the web page that opened.
  4. I typed again Pocket and this time it worked flawlessly, I had access to all my lists and I couldn't find any issues.
  5. After the workflow was properly authorized (step 3.) I didn't have any further issues. It now works every time when I open the Alfred bar and type Pocket.

devnoname120 avatar Jun 01 '23 21:06 devnoname120

@fniephaus I haven't thoroughly reviewed the code but imho it's ready for merging.

As it works with recent Alfred versions it's already a big leap forward. Making the code perfect would be a cherry on the cake that can be done in a later iteration and imho shouldn't get in the way of merging this PR. 😊

devnoname120 avatar Jun 02 '23 10:06 devnoname120