browser icon indicating copy to clipboard operation
browser copied to clipboard

Publish unreleased changes

Open aduth opened this issue 1 year ago • 1 comments

Description

There are a couple changes slated for release (see CHANGELOG.md) which have been merged for multiple years. We particularly have an interest in using the new chromium_based? method. Would you please consider publishing a new release containing these changes?

How to reproduce

require 'browser'
Browser.new('some user agent').chromium_based?

What do you expect

false

What happened instead

undefined method `chromium_based?' for #<Browser::Unknown ...> (NoMethodError)

Software:

  • Browser gem version: 5.3.1

aduth avatar Jan 11 '24 14:01 aduth

I think a workaround given the current implementation is:

browser.chrome? || browser.edge?

On that note, there may be other browsers that should also be considered as Chromium based? Being able to use the chromium_based? abstraction would be preferable to checking individual browsers to allow for changes over time.

aduth avatar Jan 11 '24 14:01 aduth

just released v6.0.0.

fnando avatar Apr 30 '24 17:04 fnando

Thank you for releasing the new version! And for maintaining this useful gem ❤️

aduth avatar May 01 '24 12:05 aduth