react-typeahead icon indicating copy to clipboard operation
react-typeahead copied to clipboard

only display options list if not empty

Open magalhas opened this issue 10 years ago • 7 comments

When there were no visible items the

    was being rendered without need.

    magalhas avatar Aug 03 '15 10:08 magalhas

    I haven't read through the rest of the code lately, but does this break anything that assumes "sel" is a valid reference anywhere else?

    fmoo avatar Aug 03 '15 16:08 fmoo

    From my experience it's not throwing any errors, but yeah the ref won't be available with this if statement.

    I wanted to put this logic inside the List component, though you can't return undefined / null on a render method.

    magalhas avatar Aug 03 '15 16:08 magalhas

    It would be awesome if this could be included so that we can stop using our fork git dependency.

    magalhas avatar Mar 10 '16 14:03 magalhas

    Can you rebase and move the logic into _shouldSkipSearch() ?

    fmoo avatar Mar 10 '16 21:03 fmoo

    @fmoo done.

    magalhas avatar Mar 11 '16 15:03 magalhas

    Hey, we've had a couple of regressions lately, would you mind including a unit test for this as well?

    fmoo avatar Mar 11 '16 18:03 fmoo

    Sure, not sure when I'll be able to pick this up though. What about my other 2 PRs?

    magalhas avatar Mar 14 '16 11:03 magalhas