Fabian Meumertzheim comments

Results 1695 comments of


                                            Fabian Meumertzheim

GoStdlib, GoCompilePkg, etc. don't respect exec_compatible_with of the underlying C/C++ toolchain

We would probably need to get rid of `cgo_context` and inline what it does into the individual rule implementations. Would you be interested in working on that?

Calls to https://go.dev/dl/?mode=json are breaking airgapped builds - provide way to avoid these

This is an interesting problem that I think can be solved by introducing an intermediate extension that records the extracted information in the `MODULE.bazel.lock` file. I'll give this some more...

Calls to https://go.dev/dl/?mode=json are breaking airgapped builds - provide way to avoid these

@peakschris When you say "don't use Git", what are you using instead and why does that prevent you from checking in MODULE.bazel.lock? Bazel 7.2.0rc1 comes with a revised lockfile format...

No way to use toolchains correctly in executable rule output

> Are those the toolchains that intentionally have exec/target_compatible_with set the wrong way around? I’ve never been a fan of that approach. I don't know how Python does this, but...

No way to use toolchains correctly in executable rule output

I agree with @BoleynSu here. The current approach is conceptually sound, the problem is that it's apparently too verbose or too hard to use correctly for simple cases that don't...

bazel crash after first run with empty lock file

Could you test this again with 7.2.0rc2?

C++: strip action ignores environment passed through toolchain features

@bazelbuild/triage Could you reopen this issue?

C++: strip action ignores environment passed through toolchain features

@tomaspipes Could you test out https://github.com/bazelbuild/bazel/pull/22590?

Use toolchain env for strip action

@pzembrod The best way to test this would be a starlark analysis test, but those aren't open-source yet. Could you maybe add one to the internal test suite?

Use toolchain env for strip action

@pzembrod The library for writing tests (rules_testing) is open-source, but the tests themselves are not. I don't think that there is any Starlark analysis test in Bazel outside the special...