Fabian Meumertzheim
Fabian Meumertzheim
I noticed one limitation that makes this solution slightly less useful than I first thought: A single annotation cannot be meta-annotated with multiple `@ArgumentsSource`s since `@ArgumentsSources` does not list `ANNOTATION_TYPE`...
@marcphilipp Since I don't know the usual processes for contributions yet: Would it help if I turned your spike into a PR with tests and docs or is this something...
Would it be possible to move the dependency on the toolchain library to `swift_binary` (assuming that's a thing)? That's how `cc_binary` handles the build-wide malloc and extra link library: https://github.com/bazelbuild/bazel/blob/6f3789aa964875b94aaa5876e4d657ce819353fa/src/main/starlark/builtins_bzl/common/cc/cc_binary_attrs.bzl#L73
I feared that that might be the case. This is indeed tricky if you don't control the top-level rule. CC @gregestren, this is an interesting case where a "reset this...
The duplication is happening because the C++ rules deduplicate the list of linkopts by reference, not by value, which does make sense since linker flags can cancel each other based...
The CI failure looks related to my hack at https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/bazel/repository/CompressedTarFunction.java;l=206;drc=10169bbe66e818868ec37f7d853ab5a567cd2ced. Let me know if you want me to take a look.
Turns out this was only an issue in Bazel's bootstrap script. Could you try adding this patch? ```diff diff --git a/scripts/bootstrap/compile.sh b/scripts/bootstrap/compile.sh index 3c49679e1a..dcc7e7f846 100755 --- a/scripts/bootstrap/compile.sh +++ b/scripts/bootstrap/compile.sh @@...
@mark-thm The `java.desktop` module increases the size of the Bazel binary by 5MB. What kind of error do you see if you remove it?
Yeah, maybe try that first. We can be pretty confident that Bazel tests are at least loading all packages that Bazel depends on.
Good point, the mailing list post referenced in the JIRA issue actually refers to the unrelated 651, not 654.