Fabian Meumertzheim comments

Results 1695 comments of


                                            Fabian Meumertzheim

[Java] Coverage not collected for some manifest jars

An idea from the sidelines: Since the stub script knows best whether it created a manifest jar, it could pass along its path as an environment variable or Java system...

Sandbox reuse preserves test`_tmp` directory

Cc @oquenchil @lberki

Sandbox reuse preserves test`_tmp` directory

@bazel-io flag

Sandbox reuse preserves test`_tmp` directory

Thanks for investigating and sorry for the false alarm - I saw the `_tmp` and thought that it was the hermetic tmp dir.

Sandbox reuse preserves test`_tmp` directory

I updated title and description.

Add DUMPBIN make variable to MSVC C/C++ toolchain

`bazel run //src/test/tools/bzlmod:update_default_lock_file` should fix this. It's necessary because it contains a hash of certain files in `@bazel_tools`.

Add DUMPBIN make variable to MSVC C/C++ toolchain

@comius @meteorcloudy

`--incompatible_sandbox_hermetic_tmp` breaks outputs materialized as a symlinks to source artifacts

@bazel-io fork 7.1.0

`--incompatible_sandbox_hermetic_tmp` breaks outputs materialized as a symlinks to source artifacts

> Make sure that an indirection through multiple symlinks works as well A tricky edge case: The output may be declared as an unresolved symlink (`ctx.actions.declare_symlink`), so we would not...

`--incompatible_sandbox_hermetic_tmp` breaks outputs materialized as a symlinks to source artifacts

I started out firmly in camp "WAI", but my opinion has changed to "we should perform this magic replacement". If it were just for the `ln -s` case, I would...