Fabian Meumertzheim

Results 1692 comments of Fabian Meumertzheim

@stefanbucur I updated the Bazel version to 5.0.0, which makes Bazel look for `python3` in `PATH`. The [CI run still fails](https://github.com/bazelbuild/rules_fuzzing/actions/runs/3467075874/jobs/5791585426#step:4:239), but when I run `/usr/bin/env python3` in `base-builder` locally,...

@stefanbucur Tests are passing now.

@jsharpe I think that you are hitting https://github.com/bazelbuild/bazel/issues/16607. If I comment out the `platforms` `http_archive` in `repositories.bzl`, the toolchain is found. Before: ```starlark $ bazel query @local_cuda//toolchain/clang:clang-local-toolchain --output=build --enable_bzlmod toolchain(...

@Wyverald I like @meteorcloudy's idea to issue a warning if a module extension contains a repo that shadows a bazel_dep's repo_name. At least if we don't see valid use cases...

@nlohmann The amalgamation check appears to run the formatter on `tests` and my tests weren't properly formatted - should be fixed now.

I will leave this in draft until I have confirmed it works over at https://github.com/bazelbuild/bazel-central-registry/pull/248.

@nlohmann I just noticed that https://github.com/nlohmann/json/pull/3709 is available at HEAD, but not in a published release. I will wait for the next release and pick this up once Bazel support...

https://github.com/bazelbuild/bazel-central-registry/pull/359 has added the module.

@Wyverald Could you review this PR? @joeleba I have trouble getting `UiStateTrackerTest` to pass in the Skymeld case. This change makes it necessary to fire a `LoadingPhaseCompleteEvent`, but that seems...

@zhengwei143 Thanks, that seems to have worked, tests are passing now.