Fabian Meumertzheim
Fabian Meumertzheim
@alexeagle None of us have worked with proto toolchains so far, so it would be great if you could also take a look.
FYI @sluongng You might find this interesting :-)
I'll take another stab at fixing the integration tests next week. Everything else is stable for review.
I updated rules_proto to 6.0.0 and fixed the remaining tests, PTAL @linzhp @tyler-french
> Just checking, will this also work for users of go.work workspaces? This requires adding the relevant files to https://github.com/bazelbuild/bazel-gazelle/blob/7c84c339075a992ea1a6f720899d91c0e047efe2/internal/bzlmod/go_deps.bzl#L657. Maybe that already happens with the fake `go.mod` files we...
The wrapper assumes that its current working directory is the execroot, but Go tooling and rules_go builders may change the cwd. Could you make it so that your wrapper finds...
Good catch, this looks clearly wrong. Would you be willing to send a PR?
@linzhp @tyler-french Would be interested in hearing your thoughts on this, let me know if you want more context.
I fixed the merge conflict and added comments to explain why these slightly more convoluted `Args` constructions are necessary.
The nogo failure looks like it's easier to fix than ignore.