Fabian Meumertzheim

Results 1688 comments of Fabian Meumertzheim

@shs96c Instead of using buildozer as a binary, could we have Gazelle depend on its Go package? It already comes with BUILD files and thus shouldn't complicate the bootstrapping situation...

@gregestren Even though this is somewhat mitigated by `--experimental_output_directory_naming_scheme=diff_against_baseline`, this still looks like a bug to me. Did you close this on purpose or would you consider merging?

At this point I am quite convinced that `diff_against_dynamic_baseline` is safe from the point of view of correctness and performance, but I still fear path length issues on Windows and...

@cameron-martin You can pass the label of a generated `constraints.bzl` file to the module extension. The `local_config_platform` module contains some helper functions for this.

@brentleyjones @cgrindel and everyone else with a use case, could you briefly describe what you would use this feature for in a comment? I can finally start working on the...

I created https://github.com/bazelbuild/bazel-skylib/pull/440 to make the string- and int-valued build settings defined there usable wherever `--define` is, using (and generating) Make variables.

How about splitting the coverage feature into one for compilation and one for linking? The one for compilation could be guarded by the instrumentation filter matching the target, whereas the...

@iancha1992 Could you reopen? I lack the permission to do so.

While looking into fixing this issue, I learned that this had already been implemented well before this issue was created: https://github.com/bazelbuild/buildtools/commit/5fa18d247b23dd7a66e4ce5f829fda1d1bf06dc0 The syntax is: ``` buildozer '' WORKSPACE: ``` More...

`bindata` is deprecated and marked for removal in 0.39.0. Going forward, `embedsrcs` is the recommended way to embed files backed by `//go:embed`. The underlying issue in Bazel is fixed in...