Fabian Meumertzheim
Fabian Meumertzheim
I think that this may not be an issue with `sh_binary`, it's an issue in `ctx.expand_locations` that is triggered by `sh_binary` returning two files in `DefaultInfo(files = ...)`. This line...
@brandjon Could you share the details of the use case that resulted in you rolling back the fix in https://github.com/bazelbuild/bazel/commit/ab71a1002c9c53a8061336e40f91204a2a32c38e?
@thesayyn A safe way to fix this would be to resubmit the reverted PR and have it use the `executable` only if the expansion would previously have failed (and explicitly...
Should have been fixed in 8.0.1 with the flip of `--incompatible_locations_prefers_executable`.
CC @comius @alexeagle
@shaod2 Would you be available to review this?
> Additionally, this PR is touching protobuf.bzl, which just contains our legacy internal macros/rules (which we want to delete). These have been replaced by the rules in //bazel, which were...
@mkruskal-google Friendly ping
@mkruskal-google Could you elaborate on what these deprecated Bazel features are? As far as I can tell, proto toolchainization is a much more robust and modern approach than `--proto_compiler` (which...
@sluongng I wonder whether running a prebuilt gazelle is the best approach with Bzlmod. Setting up gazelle requires a single line in `MODULE.bazel` (which we could add automatically) and at...