Fabian Meumertzheim
Fabian Meumertzheim
I still don't know why `watchfs_test` started to fail in CI (it does even if I revert my recent changes). I'll keep investigating this. The other tests all set some...
~Edit: Looks like explicitly setting a locale fixed the test, CI is green now.~ And then it's not.
I had to make `watchfs_test` exclusive and bump the sleeps to 5s to get it to pass on the Mac runners. It passes on my Mac with sleeps at 1s...
I addressed the comments and rebased onto master.
> The test does not actually work with ISO8859-1 as sun.jnu.encoding because then it runs into the same "unmappable character" issue Did you verify this? I think it's not true:...
@lberki You need to wrap the Unicode string literal in `unicodeToInternal` for this to work.
> I thought about this and I think the root cause of the issue is that Bazel does one thing (UTF-8), Blaze does another thing (ISO8859-1) and the tests do...
@bazel-io fork 8.3.0
> Could you add a sentence or two as RELNOTES? Done! > Also, this this change will require documentation updates (can be in followup PRs). I can add it in...
I filed https://github.com/bazelbuild/bazel/issues/26281.