tydom2mqtt icon indicating copy to clipboard operation
tydom2mqtt copied to clipboard

Identify tydom2mqtt installed version [docker]

Open jim17 opened this issue 1 year ago • 1 comments

Notes:

  • While inspecting the docker image, I couldn't find any way to identify the version.

  • The digest of "latest" tag do not match with the digest of any other tag.

Proposals:

  1. Add some __version__ variable to identify tydom2mqtt version from source files.

  2. I don't have enough docker experience to propose a solution but it would be very good to match "latest" tag digest with the numeric version digest. It would be very good to tag the docker images similar to zigbee2mqtt, from https://hub.docker.com/r/koenkk/zigbee2mqtt/tags, you could find it´s "latest" tag digest matches with "1.30.3" tag digest.

Best Regards, Miguel.

jim17 avatar Apr 16 '23 20:04 jim17

Hi,

The latest and the release digests do not match because the latest is built when a new commit is pushed to the master branch whereas the release is build when a new tag is pushed. So it leads to 2 separate builds resulting in 2 different image digests. Moreover, the master branch is most of the time in ahead the latest release because validated features/fixes are first merged to master, then, later, a new release will be packaged.

Using latest docker images is, though, handy but it's not very recommended; can't you just use the released tags (8.3.0...)? 😄

fmartinou avatar Aug 04 '23 16:08 fmartinou