glpi-plugin icon indicating copy to clipboard operation
glpi-plugin copied to clipboard

WIP Disable notifications policy

Open DIOHz0r opened this issue 6 years ago • 6 comments

Signed-off-by: Domingo Oropeza [email protected]

Changes description

Added the policy for disable all notifications on device

Checklist

Please check if your PR fulfills the following specifications:

  • [ ] Tests for the changes have been added
  • [ ] Docs have been added/updated

References

Closes #405 Depends #https://github.com/flyve-mdm/android-mdm-agent/issues/371

DIOHz0r avatar Apr 13 '18 14:04 DIOHz0r

@rafaelje, does this policy has been implemented on the current agent version?. I think this is a 2.1 plugin milestone and not 2.0

DIOHz0r avatar Jul 10 '18 14:07 DIOHz0r

@DIOHz0r Also, this string areNotificationsEnabled is not uniform with other policies.

I think disableNotifications is better for consistency with other policies.

Can we also split this policy into several policies for different notification types ?

btry avatar Jul 10 '18 14:07 btry

As far as I know there is no more options for notifications right now, could you confirm that @rafaelje ?

DIOHz0r avatar Jul 10 '18 14:07 DIOHz0r

ping @rafaelje

DIOHz0r avatar Aug 30 '18 13:08 DIOHz0r

This policy is not implemented on the agent yet is for 2.1

rafaelje avatar Aug 31 '18 15:08 rafaelje

@DIOHz0r please change the symbol of this policy, look at my old comments

btry avatar Aug 31 '18 15:08 btry