android-mdm-agent icon indicating copy to clipboard operation
android-mdm-agent copied to clipboard

WIP Improve testing and refactoring code

Open rafaelje opened this issue 6 years ago • 0 comments

Changes description

  • At this point is important to improve the mandatory test present on the core like deeplink, enrollment, permission, user, and walkthrough

The most important test on this PR is enrollment and deeplink.

The agent has a complete MVP pattern and these tests were created with the instrumented test wish make slow, in this PR I'm moving the model and presenter from instrumented test to unit test with a more clear idea for contributors.

With support for these tools on gradle just available for testing purpose:

  • Powermock To mock static class

  • Robolectric To create a real Android Context with out instrumented test

  • Mockito To create basic mocks

Checklist

Please check if your PR fulfills the following specifications:

  • [ ] Tests for the changes have been added
  • [ ] Docs have been added/updated

Estimated time

Assignee :tomato:
@rafaelje 20

References

Closes #N/A Related #N/A Depends on #N/A

rafaelje avatar Jul 09 '18 22:07 rafaelje