flytesnacks icon indicating copy to clipboard operation
flytesnacks copied to clipboard

[DOCS] add `nested_type` examples for `structured_dataset.py`

Open austin362667 opened this issue 1 year ago • 5 comments

Add structured_dataset_nested_type examples in documentation.

https://github.com/flyteorg/flytekit/pull/2252

austin362667 avatar Apr 23 '24 08:04 austin362667

Should I run pip-compile dev-requirements.in --upgrade --verbose --resolver=backtracking and pip-compile docs-requirements.in --upgrade --verbose --resolver=backtracking ?

FYR https://docs.flyte.org/projects/cookbook/en/latest/contribute.html#updating-dependencies

After running the commands, it appears that all the dependencies have been upgraded.

austin362667 avatar Apr 29 '24 17:04 austin362667

Should I run pip-compile dev-requirements.in --upgrade --verbose --resolver=backtracking and pip-compile docs-requirements.in --upgrade --verbose --resolver=backtracking ?

FYR https://docs.flyte.org/projects/cookbook/en/latest/contribute.html#updating-dependencies

After running the commands, it appears that all the dependencies have been upgraded.

I don't think you need to do that, since you're only changing the requirements for a specific example and not the entire repo -- @pingsutw does that sound right to you?

neverett avatar Apr 29 '24 18:04 neverett

Got it, thank you!

austin362667 avatar Apr 29 '24 20:04 austin362667

right, you don't need to run pip-compile

pingsutw avatar Apr 30 '24 09:04 pingsutw

@austin362667 I tried rerunning the failing tests, but I think you'll need to merge master into your branch to get the tests to pass.

neverett avatar Apr 30 '24 16:04 neverett

This change is causing a general slowdown in flytesnacks CI checks in master, e.g.: https://github.com/flyteorg/flytesnacks/actions/runs/8978906994/job/24696216089

eapolinario avatar May 07 '24 22:05 eapolinario