flyteplugins icon indicating copy to clipboard operation
flyteplugins copied to clipboard

Add docker credential to databricks job config

Open pingsutw opened this issue 2 years ago • 1 comments

TL;DR

Read the docker username and passport from the secret, and add this credential to the Databricks job config. https://docs.databricks.com/api/workspace/jobs/create

Type

  • [x] Bug Fix
  • [ ] Feature
  • [ ] Plugin

Are all requirements met?

  • [ ] Code completed
  • [ ] Smoke tested
  • [ ] Unit tests added
  • [ ] Code documentation added
  • [ ] Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

https://flyte-org.slack.com/archives/CP2HDHKE1/p1686928788919089

Follow-up issue

NA

pingsutw avatar Jun 21 '23 06:06 pingsutw

Codecov Report

Merging #364 (44f626f) into master (dfdf6f9) will decrease coverage by 0.02%. The diff coverage is 45.45%.

:exclamation: Current head 44f626f differs from pull request most recent head cbe51c2. Consider uploading reports for the commit cbe51c2 to get more accurate results

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   64.05%   64.04%   -0.02%     
==========================================
  Files         152      152              
  Lines       10392    10400       +8     
==========================================
+ Hits         6657     6661       +4     
- Misses       3124     3126       +2     
- Partials      611      613       +2     
Impacted Files Coverage Δ
go/tasks/plugins/webapi/databricks/plugin.go 65.04% <45.45%> (-0.61%) :arrow_down:

codecov[bot] avatar Jun 21 '23 06:06 codecov[bot]